Remove control-value tracking from Flutter SDK - #31
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes all control-value and semantic-annotation capture from the Tugboat Flutter SDK, establishing a breaking compatibility boundary at package 0.5.0 and session schema v9 while preserving structural interaction replay.
Changes:
- Stop emitting
controlValue,controlValueTransition, andsemanticAnnotationin event payloads; bump session schema writers tov9. - Remove public APIs and internal implementation for control-value and semantic-annotation extraction/merging.
- Update tests and documentation to reflect the new privacy/telemetry model and verify legacy JSON readability (v6–v8) alongside v9 writers.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/tugboat/test/tugboat_replay_test.dart | Updates replay tests to assert value/semantic telemetry is not emitted and bumps expected schema version to 9. |
| packages/tugboat/test/semantics_flags_compat_test.dart | Simplifies semantics flags compatibility tests to match reduced compat surface. |
| packages/tugboat/test/integration/release_compatibility_matrix_test.dart | Adjusts compatibility test to validate v6–v8 readability with v9 writers and legacy value fields present only in historic JSON. |
| packages/tugboat/test/helpers/json_roundtrip.dart | Extends test-only JSON reader to accept schema version 9. |
| packages/tugboat/test/fingerprint_test.dart | Adds regression coverage for typed Radio<T> role detection and anchor resolution. |
| packages/tugboat/test/control_value_test.dart | Removes control-value/semantic-annotation telemetry test suite consistent with feature removal. |
| packages/tugboat/README.md | Documents 0.5.0 breaking change, schema v9, removed exports, and updated telemetry guarantees. |
| packages/tugboat/pubspec.yaml | Bumps package version to 0.5.0. |
| packages/tugboat/lib/tugboat.dart | Removes barrel exports for control-value and semantic-annotation public APIs and helpers. |
| packages/tugboat/lib/src/widget_roles.dart | Hardens Radio/RadioListTile enablement inspection to avoid generic callback cast hazards. |
| packages/tugboat/lib/src/semantics_flags_compat.dart | Removes checked/toggled/selected compat helpers, retaining enabled-state compat only. |
| packages/tugboat/lib/src/sdk_version.dart | Updates embedded SDK version constant to 0.5.0. |
| packages/tugboat/lib/src/models.dart | Bumps tugboatSessionSchemaVersion to 9 and updates schema documentation. |
| packages/tugboat/lib/src/interaction_transaction.dart | Removes control/semantic metadata fields from interaction transaction model and result serialization. |
| packages/tugboat/lib/src/controller.dart | Eliminates control-value/semantic capture and post-frame resampling; removes corresponding event payload fields. |
| packages/tugboat/lib/src/control_value.dart | Removes the entire control-value + semantic-annotation implementation. |
| packages/tugboat/lib/src/anchors.dart | Drops control_value.dart part and now-unneeded imports. |
| packages/tugboat/lib/src/anchor_resolver.dart | Removes interaction metadata sampling/resampling and semantic annotation helpers; tap context now returns only inventory + target. |
| packages/tugboat/example/test/widget_test.dart | Removes example tests that depended on semantic-annotation payload emission. |
| packages/tugboat/example/pubspec.yaml | Updates example dependency constraint to tugboat: ^0.5.0. |
| packages/tugboat/example/lib/screens/profile_screen.dart | Removes example UI that existed primarily to demonstrate semantic parameter/value capture. |
| packages/tugboat/CHANGELOG.md | Adds 0.5.0 changelog entry documenting breaking removals and schema v9 behavior. |
| docs/README.md | Updates docs “current compatibility” values to 0.5.0 / schema 9. |
| docs/design/capture-and-fingerprint.md | Updates design docs to reflect schema v9 and removal of value/semantic event telemetry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.5.0with session schema v9 and migration guidance.Why
The SDK should not track control values or semantic label/value telemetry. Structural replay data remains available without those fields.
Compatibility
Consumers of historic schemas v6-v8 should tolerate the removed fields as optional historic data. New captures emit schema v9 without
controlValue,controlValueTransition, orsemanticAnnotation.Validation
dart run melos run analyzeflutter test --concurrency=1 --reporter compactinpackages/tugboat(296 passed)The default parallel Flutter runner is flaky in this checkout; the serial package-local suite is green.